Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/net/http: ensure NewServeMux respects WithResourceNamer option #1436

Merged
merged 2 commits into from Sep 28, 2022
Merged

contrib/net/http: ensure NewServeMux respects WithResourceNamer option #1436

merged 2 commits into from Sep 28, 2022

Conversation

mccutchen
Copy link
Contributor

Fixes #1435.

@mccutchen mccutchen requested a review from a team August 18, 2022 15:11
katiehockman
katiehockman previously approved these changes Sep 2, 2022
Copy link
Contributor

@katiehockman katiehockman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks 👍

Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution!

@ajgajg1134 ajgajg1134 merged commit f148b10 into DataDog:main Sep 28, 2022
Hellzy pushed a commit that referenced this pull request Sep 30, 2022
Fixes #1435.

Co-authored-by: Andrew Glaude <andrew.glaude@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contrib/net/http: NewServeMux does not respect WithResourceNamer option
4 participants