Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed links to internal resources #1404

Merged
merged 4 commits into from Aug 1, 2022
Merged

Removed links to internal resources #1404

merged 4 commits into from Aug 1, 2022

Conversation

dianashevchenko
Copy link
Contributor

References PRs #1350 and #1346

  • multipleIPHeaders is documented to be used internally, so I removed it from ext/tags.go list of public API tags
  • removed links to internal resources

TODO:

@dianashevchenko dianashevchenko requested a review from a team July 29, 2022 12:48
@dianashevchenko dianashevchenko added this to the 1.41.0 milestone Jul 29, 2022
@dianashevchenko
Copy link
Contributor Author

cc @Hellzy

ajgajg1134
ajgajg1134 previously approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Hellzy
Hellzy reviewed Aug 1, 2022
View reviewed changes
Copy link
Contributor

@Hellzy Hellzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup Diana 👍

contrib/internal/httptrace/config.go Show resolved Hide resolved
contrib/internal/httptrace/httptrace.go Show resolved Hide resolved
contrib/internal/httptrace/httptrace.go Show resolved Hide resolved
@dianashevchenko dianashevchenko merged commit 9ffc9ef into main Aug 1, 2022
@dianashevchenko dianashevchenko deleted the shevchenko/removed-internal-links branch August 1, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hellzy Hellzy Hellzy left review comments

@ajgajg1134 ajgajg1134 ajgajg1134 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dianashevchenko @ajgajg1134 @Hellzy