Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiler: disable TestStopLatency #1295

Merged
merged 2 commits into from
May 16, 2022

Conversation

nsrip-dd
Copy link
Contributor

The test needs to be re-evaluated as it should never have passed in the first place. See issue #1294.

The test needs to be re-evaluated as it should never have passed in the
first place. See issue #1294.
@nsrip-dd nsrip-dd requested a review from a team as a code owner May 14, 2022 14:05
@nsrip-dd nsrip-dd added this to the 1.39.0 milestone May 14, 2022
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with merging this. But see #1294 (comment) for a potential "fix". Let me know what you think.

@nsrip-dd
Copy link
Contributor Author

I'll merge this for now until I find time to follow up with a test fix.

@nsrip-dd nsrip-dd merged commit 06c3a1d into v1 May 16, 2022
@nsrip-dd nsrip-dd deleted the nick.ripley/disable-profiler-latency-test branch May 16, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants