Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws: add request id to trace #1266

Merged
merged 2 commits into from May 2, 2022
Merged

aws: add request id to trace #1266

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f72716b
aws: add request id to trace
yulius-take2 Apr 29, 2022
8827bac
add request id unit test
yulius-take2 Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions contrib/aws/aws-sdk-go/aws/aws.go
View file
Open in desktop
Expand Up @@ -24,6 +24,7 @@ const (
tagAWSOperation = "aws.operation"
tagAWSRegion = "aws.region"
tagAWSRetryCount = "aws.retry_count"
tagAWSRequestID = "aws.request_id"
)

type handlers struct {
Expand Down Expand Up @@ -78,6 +79,7 @@ func (h *handlers) Complete(req *request.Request) {
return
}
span.SetTag(tagAWSRetryCount, req.RetryCount)
span.SetTag(tagAWSRequestID, req.RequestID)
yulius-take2 marked this conversation as resolved.
Show resolved Hide resolved
if req.HTTPResponse != nil {
span.SetTag(ext.HTTPCode, strconv.Itoa(req.HTTPResponse.StatusCode))
}
Expand Down