Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: commit full go.mod and go.sum files #1188

Merged
merged 9 commits into from Mar 7, 2022
Merged

Commits on Feb 28, 2022

  1. all: commit full go.mod and go.sum

    To address repeated CI failure due to missing dependencies in go.mod
    leading to backward-incompatible upgrades, fully specify all
    dependencies in go.mod.
    
    The go.mod file was created by starting from the original go.mod, then
    applying all of the "go get" commands from .circleci/config.yml using
    go1.14, including an additional upgrade to
    google.golang.org/grpc@v1.32.0 to satisfy the requirements of
    internal/traceprof/testapp. Then I ran "go1.14 mod tidy" and finally the
    unit tests to make sure go.sum was fully up-to-date.
    
    This change may lead to breaking builds down-stream if users are
    upgraded (via our go.mod) to newer versions of libraries which ignore
    semver like grpc. However, unless and until integrations are moved to
    separate go.mod files, we need to specify *some* minimum supported
    version of every dependency so that users of the integrations know which
    version to get and so that our CI is not constantly breaking.
    nsrip-dd committed Feb 28, 2022
    Copy the full SHA
    d78f0bf View commit details
    Browse the repository at this point in the history
  2. .circleci: don't try to pin dependencies

    This should not be necessary now that we have fully populate go.mod and
    go.sum.
    nsrip-dd committed Feb 28, 2022
    Copy the full SHA
    98c6eac View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2022

  1. all: downgrade versions in go.mod to minimum compatible

    Wherever possible, downgraded the required versions of direct imports in
    go.mod to be the minimum that would 1) compile, 2) pass tests locally,
    and 3) didn't have security vulnerabilities listed on pkg.go.dev.
    
    Still need to verify that the integration tests pass. Having lower
    versions listed where possible should reduce the likelihood of
    downstream users getting unintentionally upgraded.
    nsrip-dd committed Mar 2, 2022
    Copy the full SHA
    9259022 View commit details
    Browse the repository at this point in the history
  2. go.mod: update github.com/elastic/go-elasticsearch/v6 to v6.8.5

    This is the earliest version that actually passes the integration tests.
    nsrip-dd committed Mar 2, 2022
    Copy the full SHA
    1854f80 View commit details
    Browse the repository at this point in the history
  3. go.mod: updated gorm.io/gorm to v1.20.6

    This is the earliest version that passes the integration tests.
    nsrip-dd committed Mar 2, 2022
    Copy the full SHA
    36a3a69 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2022

  1. go.mod: downgrade google.golang.org/grpc to v1.32.0

    I thought I did this before but I guess not. This is the minimum version
    required by internal/traceprof for its protobuf code.
    nsrip-dd committed Mar 3, 2022
    Copy the full SHA
    3b73773 View commit details
    Browse the repository at this point in the history
  2. go.mod: bump google.golang.org/api to v0.29.0

    That version introduced an API change (breaking, of couse) that the test
    relies on.
    nsrip-dd committed Mar 3, 2022
    Copy the full SHA
    f4f347d View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Copy the full SHA
    6c89355 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    a56b650 View commit details
    Browse the repository at this point in the history