Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc_test.go: Add test for using the NoDebugStack() option #1185

Closed
wants to merge 1 commit into from

Conversation

evanj
Copy link
Contributor

@evanj evanj commented Feb 28, 2022

Also add WithEnv and WithServiceVersion() options, since that
should more accurately represents how tracing and the interceptor is
typically configured. Example output now looks like:

goos: darwin
goarch: amd64
pkg: gopkg.in/DataDog/dd-trace-go.v1/contrib/google.golang.org/grpc
cpu: Intel(R) Core(TM) i7-8569U CPU @ 2.80GHz
BenchmarkUnaryServerInterceptor/ok_no_metadata-8         	  205440	      5295 ns/op	    5006 B/op	      53 allocs/op
BenchmarkUnaryServerInterceptor/ok_with_metadata_no_parent-8         	  189415	      6144 ns/op	    5635 B/op	      58 allocs/op
BenchmarkUnaryServerInterceptor/ok_with_metadata_with_parent-8       	  219744	      5451 ns/op	    4724 B/op	      49 allocs/op
BenchmarkUnaryServerInterceptor/ok_no_metadata_with_analytics_rate-8 	  214992	      5470 ns/op	    5214 B/op	      55 allocs/op
BenchmarkUnaryServerInterceptor/error_no_metadata-8                  	   91838	     12414 ns/op	   11397 B/op	      70 allocs/op
BenchmarkUnaryServerInterceptor/error_no_metadata_no_stack-8         	  169959	      6638 ns/op	    6312 B/op	      57 allocs/op

Add WithEnv and WithServiceVersion() options, since hopefully that
represents how this is typically configured.
@evanj evanj requested a review from a team February 28, 2022 14:20
@evanj
Copy link
Contributor Author

evanj commented Feb 28, 2022

Oops I split this into #1160 which has still not yet been merged. That PR should be merged instead. Closing.

@evanj evanj closed this Feb 28, 2022
@evanj evanj deleted the evan.jones/grpc-benchmark-unary-2 branch February 28, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant