Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddtrace/tracer.Measured(): Cache a global instance (save 1 alloc/call) #1184

Merged
merged 2 commits into from Mar 8, 2022
Merged

ddtrace/tracer.Measured(): Cache a global instance (save 1 alloc/call) #1184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dfa92b
ddtrace/tracer.Measured(): Cache a global instance (save 1 alloc/call)
evanj Jan 20, 2022
9e6abba
Merge branch 'v1' into evan.jones/tracer-measured-cache
Julio-Guerra Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion ddtrace/tracer/option.go
View file
Open in desktop
Expand Up @@ -741,9 +741,12 @@ func SpanType(name string) StartSpanOption {
return Tag(ext.SpanType, name)
}

var measuredTag = Tag(keyMeasured, 1)

// Measured marks this span to be measured for metrics and stats calculations.
func Measured() StartSpanOption {
return Tag(keyMeasured, 1)
// cache a global instance of this tag: saves one alloc/call
return measuredTag
}

// WithSpanID sets the SpanID on the started span, instead of using a random number.
Expand Down