Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/google.golang.org/grpc: Reduce allocs in interceptor #1183

Merged
merged 2 commits into from Mar 8, 2022
Merged

contrib/google.golang.org/grpc: Reduce allocs in interceptor #1183

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95e2894
contrib/google.golang.org/grpc: Reduce allocs in interceptor
evanj Jan 20, 2022
efd8399
Merge branch 'v1' into evan.jones/allocs-finish
Julio-Guerra Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 9 additions & 5 deletions contrib/google.golang.org/grpc/grpc.go
View file
Open in desktop
Expand Up @@ -48,11 +48,15 @@ func finishWithError(span ddtrace.Span, err error, cfg *config) {
err = nil
}
span.SetTag(tagCode, errcode.String())
finishOptions := []tracer.FinishOption{
tracer.WithError(err),
}
if cfg.noDebugStack {
finishOptions = append(finishOptions, tracer.NoDebugStack())

// only allocate finishOptions if needed, and allocate the exact right size
var finishOptions []tracer.FinishOption
if err != nil {
if cfg.noDebugStack {
finishOptions = []tracer.FinishOption{tracer.WithError(err), tracer.NoDebugStack()}
} else {
finishOptions = []tracer.FinishOption{tracer.WithError(err)}
}
}
span.Finish(finishOptions...)
}