contrib/gorilla/mux: add router wrapper #1175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on user feedback we had that didn't want to totally replace their gorilla/mux imports by ours, we would like to propose them the alternative of rather importing our contrib to wrap their gorilla router instead. To do so, we introduced a new function called
WrapRouter()
that wraps the given gorilla mux router with our wrapper.Note that a pure gorilla middleware is not a good option for us because they do not get called when the route is not found, leading the missing all the 404 on routes that were not found on the router. This impacts both the APM tracing and the AppSec monitoring. So the current solution with
WrapRouter
instead is the best possible solution to be able to monitor every request entering the router.