New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiler, ddtrace/tracer: enable code hotspots & endpoints by default with 100% CPU profiling #1169
Conversation
After testing this default on many high-volume internal workloads, we've determined this default is safe for production. It's also important for the code hotspots feature to be able to associated as many traces as possible with profiling data.
After testing the feature internally on several high-volume workloads, we've determined this feature can be safely enabled by default for production workloads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but seems like CI is broken due to go.mod issues again : /. Would you mind taking a look or talking to @DataDog/tracing-go to get it fixed before merging?
8378cd9
to
fd5a429
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good to me! Is there any documentation anywhere that also needs to change?
Thanks Andrew! I updated the package doc comments for the code hotspots and endpoint options which should cover it for this repo. I'll make sure the default is also documented in the other Datadog docs. |
After testing code hotspots & endpoints together with 100% CPU profiling internally, we've determined that the features have minimal overhead for production workloads and can be safely enabled by default.