New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/database/sql: trace connection time #1154
contrib/database/sql: trace connection time #1154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I just have a few questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more questions, but looks good. I'd also recommend you try this out and run it against the actual Datadog UI/app and make sure that what shows up there is what's expected.
Yep! I ran this against a local postgres instance with the datadog agent and verified that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work Andrew! Thanks for doing this. 🚀
We can also test this in our internal reliability env. I'll ping you in slack about it. |
@ajgajg1134 sorry for the random ping on this: Do you remember if this also traces time spent while waiting on an already established connection from the pool (b/c the max connection limit has been reached)? |
This builds on PR #794
Fixed #760