Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddtrace/tracer: don't use UTC() when getting time #1134

Merged
merged 3 commits into from Mar 8, 2022
Merged

ddtrace/tracer: don't use UTC() when getting time #1134

merged 3 commits into from Mar 8, 2022

Commits on Jan 20, 2022

  1. ddtrace/tracer/time.now(): Don't call .UTC() 

    Unix time is defined as the duration since January 1, 1970 UTC.
Calling .UTC() does unnecessary work to convert the "location" field
of the time.Time object. The disassembly shows this new
implementation is a few instructions shorter, but I doubt this will
have any measurable performance impact. This is more about
simplifying the existing code.
    @evanj
    evanj committed Jan 20, 2022
    Copy the full SHA
    6db9e3c View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. time_windows.go: Make the same change to lowPrecisionNow

    @evanj
    evanj committed Jan 21, 2022
    Copy the full SHA
    8a51387 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Merge branch 'v1' into evan.jones/time-now

    @Julio-Guerra
    Julio-Guerra committed Mar 8, 2022
    Copy the full SHA
    39e56a9 View commit details
    Browse the repository at this point in the history