Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability for dd trace v1.40.1, update labstack/echo to v4.9.0 #1458

Closed
Nitjsefni7 opened this issue Sep 6, 2022 · 1 comment
Closed

Comments

@Nitjsefni7
Copy link

See:
labstack/echo/issues/2259

Vulnerability:
sonatype-2022-5436

originated from labstack/echo/v4@v4.2.0

Using
replace github.com/labstack/echo/v4 v4.2.0 => github.com/labstack/echo/v4 v4.9.0
for now.

@ajgajg1134
Copy link
Contributor

Thanks for the heads-up, It's not well documented currently (I will create a PR shortly), but dd-trace-go tries to support the lowest possible version for contrib packages so that users of dd-trace-go are able to use whatever version they desire*. It looks like you've also already identified a fix for your service using the replace directive. (And users who are not using labstack/echo are unaffected)

I'll bring this up at a team meeting tomorrow to see if there's a better way to approach this problem. If you have any thoughts feel free to re-open this issue!

*Even for versions that have vulnerabilities as there exist users of dd-trace-go who either are unable or unwilling to update these dependencies.

2dvorak added a commit to 2dvorak/klaytn that referenced this issue Nov 11, 2022
The module DataDog/dd-trace-go imports labstack/echo v4.2.0,
which has vulnerability. Thus force go.mod to use patched version
v4.9.0 instead, by adding `replace` directive.
Reference: DataDog/dd-trace-go#1458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants