profiler, ddtrace/tracer: enable code hotspots & endpoints by default with 100% CPU profiling #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After testing this default on many high-volume internal workloads, we've determined this default is safe for production. It's also important for the code hotspots feature to be able to associated as many traces as possible with profiling data.
After testing the feature internally on several high-volume workloads, we've determined this feature can be safely enabled by default for production workloads.
felixge
previously approved these changes
Feb 15, 2022
nsrip-dd
force-pushed
the
nick.ripley/hotspots-endpoints-default
branch
from
8378cd9
to
fd5a429
Compare
ajgajg1134
approved these changes
Feb 16, 2022
|
Thanks Andrew! I updated the package doc comments for the code hotspots and endpoint options which should cover it for this repo. I'll make sure the default is also documented in the other Datadog docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing code hotspots & endpoints together with 100% CPU profiling internally, we've determined that the features have minimal overhead for production workloads and can be safely enabled by default.