tracer: check for invalid reflection before checking is nil

DataDog · Jun 12, 2023 · a58099a · a58099a
1 parent ca97dad
commit a58099a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/ddtrace/tracer/option.go b/ddtrace/tracer/option.go
@@ -893,7 +893,11 @@ func FinishTime(t time.Time) FinishOption {
 // err to set tags such as the error message, error type and stack trace. It has
 // no effect if the error is nil.
 func WithError(err error) FinishOption {
-	if err == nil || reflect.ValueOf(err).IsNil() {
+	if err == nil {
+		return func(_ *ddtrace.FinishConfig) {}
+	}
+	v := reflect.ValueOf(err)
+	if !v.IsValid() || v.IsNil() {
 		return func(_ *ddtrace.FinishConfig) {}
 	}
 	return func(cfg *ddtrace.FinishConfig) {