Skip to content

Commit

Permalink
profiler: rename pid tag to process_id (#1296)
Browse files Browse the repository at this point in the history
The profiler is tagging profiles with the "pid" tag whereas other Datadog
products use a different tag – "process_id".

Based on internal discussions, we decided to align on "process_id".

See PROF-5111 for more details.
  • Loading branch information
felixge committed May 16, 2022
1 parent 86a56ed commit a2f20c6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion profiler/options.go
Expand Up @@ -204,7 +204,7 @@ func defaultConfig() (*config, error) {
mutexFraction: DefaultMutexFraction,
uploadTimeout: DefaultUploadTimeout,
maxGoroutinesWait: 1000, // arbitrary value, should limit STW to ~30ms
tags: []string{fmt.Sprintf("pid:%d", os.Getpid())},
tags: []string{fmt.Sprintf("process_id:%d", os.Getpid())},
deltaProfiles: internal.BoolEnv("DD_PROFILING_DELTA", true),
logStartup: true,
}
Expand Down
2 changes: 1 addition & 1 deletion profiler/upload_test.go
Expand Up @@ -71,7 +71,7 @@ func TestTryUpload(t *testing.T) {
"env:my-env",
"tag1:1",
"tag2:2",
fmt.Sprintf("pid:%d", os.Getpid()),
fmt.Sprintf("process_id:%d", os.Getpid()),
fmt.Sprintf("profiler_version:%s", version.Tag),
fmt.Sprintf("runtime_version:%s", strings.TrimPrefix(runtime.Version(), "go")),
fmt.Sprintf("runtime_compiler:%s", runtime.Compiler),
Expand Down

0 comments on commit a2f20c6

Please sign in to comment.