Skip to content

Commit

Permalink
contrib: nit changes for PR
Browse files Browse the repository at this point in the history
  • Loading branch information
zarirhamza committed Nov 16, 2022
1 parent 4329499 commit 96f5585
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 9 deletions.
2 changes: 1 addition & 1 deletion contrib/aws/aws-sdk-go-v2/aws/aws.go
Expand Up @@ -78,7 +78,7 @@ func (mw *traceMiddleware) startTraceMiddleware(stack *middleware.Stack) error {
tracer.Tag(tagAWSOperation, operation),
tracer.Tag(tagAWSService, serviceID),
tracer.StartTime(ctx.Value(spanTimestampKey{}).(time.Time)),
tracer.Tag(ext.Component, "aws/aws-sdk-go/aws"),
tracer.Tag(ext.Component, "aws/aws-sdk-go-v2/aws"),
tracer.Tag(ext.SpanKind, ext.SpanKindClient),
}
if !math.IsNaN(mw.cfg.analyticsRate) {
Expand Down
2 changes: 1 addition & 1 deletion contrib/aws/aws-sdk-go-v2/aws/aws_test.go
Expand Up @@ -79,7 +79,7 @@ func TestAppendMiddleware(t *testing.T) {
}
assert.Equal(t, "POST", s.Tag(ext.HTTPMethod))
assert.Equal(t, server.URL+"/", s.Tag(ext.HTTPURL))
assert.Equal(t, "aws/aws-sdk-go/aws", s.Tag(ext.Component))
assert.Equal(t, "aws/aws-sdk-go-v2/aws", s.Tag(ext.Component))
assert.Equal(t, ext.SpanKindClient, s.Tag(ext.SpanKind))
})
}
Expand Down
3 changes: 0 additions & 3 deletions contrib/globalsign/mgo/mgo_test.go
Expand Up @@ -136,7 +136,6 @@ func TestCollection_Update(t *testing.T) {
assert.Equal(3, len(spans))
assert.Equal("mongodb.query", spans[1].OperationName())
assert.Equal(ext.SpanKindClient, spans[1].Tag(ext.SpanKind))

}

func TestCollection_UpdateId(t *testing.T) {
Expand Down Expand Up @@ -210,7 +209,6 @@ func TestCollection_Upsert(t *testing.T) {
assert.Equal(6, len(spans))
assert.Equal("mongodb.query", spans[1].OperationName())
assert.Equal("mongodb.query", spans[4].OperationName())

}

func TestCollection_UpdateAll(t *testing.T) {
Expand Down Expand Up @@ -253,7 +251,6 @@ func TestCollection_FindId(t *testing.T) {

spans := testMongoCollectionCommand(assert, insert)
assert.Equal(6, len(spans))

}

func TestCollection_Remove(t *testing.T) {
Expand Down
2 changes: 0 additions & 2 deletions contrib/google.golang.org/grpc/grpc_test.go
Expand Up @@ -145,8 +145,6 @@ func TestStreaming(t *testing.T) {
}
assert.NotNil(t, rootSpan)
for _, span := range spans {
//assert.Equal(t, 1, 2,
// "expected span to to have its trace id set to the root trace id %v", span)
if span != rootSpan {
assert.Equal(t, rootSpan.TraceID(), span.TraceID(),
"expected span to to have its trace id set to the root trace id (%d): %v",
Expand Down
1 change: 0 additions & 1 deletion contrib/hashicorp/vault/vault_test.go
Expand Up @@ -136,7 +136,6 @@ func testMountReadWrite(c *api.Client, t *testing.T) {
assert.Nil(span.Tag("vault.namespace"))
assert.Equal("hashicorp/vault", span.Tag(ext.Component))
assert.Equal(ext.SpanKindClient, span.Tag(ext.SpanKind))

})

t.Run("write", func(t *testing.T) {
Expand Down
1 change: 0 additions & 1 deletion contrib/julienschmidt/httprouter/httprouter_test.go
Expand Up @@ -46,7 +46,6 @@ func TestHttpTracer200(t *testing.T) {
assert.Equal(nil, s.Tag(ext.Error))
assert.Equal("julienschmidt/httprouter", s.Tag(ext.Component))
assert.Equal(ext.SpanKindServer, s.Tag(ext.SpanKind))

}

func TestHttpTracer500(t *testing.T) {
Expand Down

0 comments on commit 96f5585

Please sign in to comment.