Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Julio Guerra <julio@datadog.com>
  • Loading branch information
Hellzy and Julio-Guerra committed Feb 23, 2022
1 parent 9c62148 commit 827d566
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion contrib/gorilla/mux/mux_test.go
Expand Up @@ -403,6 +403,5 @@ func TestAppSec(t *testing.T) {
require.NotNil(t, event)
require.True(t, strings.Contains(event, "server.response.status"))
require.True(t, strings.Contains(event, "nfd-000-001"))

})
}
2 changes: 0 additions & 2 deletions contrib/labstack/echo.v4/echotrace.go
Expand Up @@ -55,12 +55,10 @@ func Middleware(opts ...Option) echo.MiddlewareFunc {
// pass the span through the request context
c.SetRequest(request.WithContext(ctx))
// serve the request to the next middleware

if appsecEnabled {
afterMiddleware := useAppSec(c, span)
defer afterMiddleware()
}

err := next(c)
if err != nil {
finishOpts = append(finishOpts, tracer.WithError(err))
Expand Down
1 change: 0 additions & 1 deletion contrib/labstack/echo.v4/echotrace_test.go
Expand Up @@ -386,7 +386,6 @@ func TestAppSec(t *testing.T) {
require.NotNil(t, event)
require.True(t, strings.Contains(event, "server.response.status"))
require.True(t, strings.Contains(event, "nfd-000-001"))

})
})
}

0 comments on commit 827d566

Please sign in to comment.