contrib/google.golang.org/grpc: Reduce allocs in interceptor (#1183)

DataDog · Mar 8, 2022 · 7c11ba8 · 7c11ba8
1 parent 7d066c1
commit 7c11ba8
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/contrib/google.golang.org/grpc/grpc.go b/contrib/google.golang.org/grpc/grpc.go
@@ -48,11 +48,15 @@ func finishWithError(span ddtrace.Span, err error, cfg *config) {
 		err = nil
 	}
 	span.SetTag(tagCode, errcode.String())
-	finishOptions := []tracer.FinishOption{
-		tracer.WithError(err),
-	}
-	if cfg.noDebugStack {
-		finishOptions = append(finishOptions, tracer.NoDebugStack())
+
+	// only allocate finishOptions if needed, and allocate the exact right size
+	var finishOptions []tracer.FinishOption
+	if err != nil {
+		if cfg.noDebugStack {
+			finishOptions = []tracer.FinishOption{tracer.WithError(err), tracer.NoDebugStack()}
+		} else {
+			finishOptions = []tracer.FinishOption{tracer.WithError(err)}
+		}
 	}
 	span.Finish(finishOptions...)
 }