QoL improvements for benchmarks

DataDog · Dec 7, 2022 · 2780eb4 · 2780eb4
1 parent 5ac4f70
commit 2780eb4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.gitlab/benchmarks.yml b/.gitlab/benchmarks.yml
@@ -15,7 +15,7 @@ benchmark:
   script:
     - ./.gitlab/scripts/capture-hardware-software-info.sh
     - ./.gitlab/scripts/run-benchmarks.sh
-    # - ./.gitlab/scripts/upload-results-to-s3.sh #commented out until we have merged our permissions changes
+    - ./.gitlab/scripts/upload-results-to-s3.sh
     - ./.gitlab/scripts/analyze-results.sh
     - ./.gitlab/scripts/post-pr-comment.sh
   artifacts:

diff --git a/.gitlab/scripts/analyze-results.sh b/.gitlab/scripts/analyze-results.sh
@@ -4,6 +4,10 @@ ARTIFACTS_DIR="/artifacts/${CI_JOB_ID}"
 REPORTS_DIR="$(pwd)/reports/"
 mkdir "${REPORTS_DIR}" || :
 
+# Change threshold for detection of regression
+# @see https://github.com/DataDog/relenv-benchmark-analyzer#what-is-a-significant-difference
+UNCONFIDENCE_THRESHOLD=2.0
+
 BASELINE_BRANCH=$(github-find-merge-into-branch --for-repo="$CI_PROJECT_NAME" --for-pr="$CI_COMMIT_REF_NAME" || :)
 
 source /benchmark-analyzer/.venv/bin/activate

diff --git a/.gitlab/scripts/post-pr-comment.sh b/.gitlab/scripts/post-pr-comment.sh
@@ -2,4 +2,4 @@
 
 REPORTS_DIR="$(pwd)/reports/"
 
-cat ${REPORTS_DIR}/report.md | /usr/local/bin/pr-commenter --for-repo="$CI_PROJECT_NAME" --for-pr="$CI_COMMIT_REF_NAME" --header="Benchmarks"
+cat ${REPORTS_DIR}/report.md | /usr/local/bin/pr-commenter --for-repo="$CI_PROJECT_NAME" --for-pr="$CI_COMMIT_REF_NAME" --header="Benchmarks" --on-duplicate=replace