[CI Visibility] - Add retries support for IOException in the coverage collector #3726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
approved these changes
Jan 30, 2023
tracer/src/Datadog.Trace.Coverage.collector/CoverageCollector.cs
Outdated
Show resolved
Hide resolved
| lstExceptions ??= new List<Exception>(); | ||
| lstExceptions.Add(ioException); | ||
| Thread.Sleep(1000); | ||
| goto Retry; |
There was a problem hiding this comment.
👀 Haha hungarian notation and goto 😄
Datadog ReportBranch report: ❄️ New Flaky Tests (1)
|
Benchmarks Report 🐌Benchmarks for #3726 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (3726) - mean (3,323ms) : 3243, 3403
. : milestone, 3323,
master - mean (3,322ms) : 3276, 3368
. : milestone, 3322,
section CallTarget+Inlining+NGEN
This PR (3726) - mean (3,326ms) : 3249, 3402
. : milestone, 3326,
master - mean (3,312ms) : 3232, 3393
. : milestone, 3312,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (3726) - mean (3,374ms) : 3290, 3458
. : milestone, 3374,
master - mean (3,389ms) : 3270, 3508
. : milestone, 3389,
section CallTarget+Inlining+NGEN
This PR (3726) - mean (3,369ms) : 3304, 3434
. : milestone, 3369,
master - mean (3,365ms) : 3305, 3426
. : milestone, 3365,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (3726) - mean (3,334ms) : 3240, 3428
. : milestone, 3334,
master - mean (3,341ms) : 3283, 3399
. : milestone, 3341,
section CallTarget+Inlining+NGEN
This PR (3726) - mean (3,337ms) : 3263, 3411
. : milestone, 3337,
master - mean (3,342ms) : 3250, 3434
. : milestone, 3342,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (3726) - mean (198ms) : 185, 211
. : milestone, 198,
master - mean (202ms) : 186, 218
. : milestone, 202,
section CallTarget+Inlining+NGEN
This PR (3726) - mean (201ms) : 184, 218
. : milestone, 201,
master - mean (200ms) : 188, 211
. : milestone, 200,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (3726) - mean (265ms) : 249, 281
. : milestone, 265,
master - mean (263ms) : 252, 274
. : milestone, 263,
section CallTarget+Inlining+NGEN
This PR (3726) - mean (264ms) : 250, 278
. : milestone, 264,
master - mean (264ms) : 245, 282
. : milestone, 264,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (3726) - mean (253ms) : 239, 267
. : milestone, 253,
master - mean (251ms) : 241, 261
. : milestone, 251,
section CallTarget+Inlining+NGEN
This PR (3726) - mean (253ms) : 244, 261
. : milestone, 253,
master - mean (254ms) : 243, 266
. : milestone, 254,
|
Throughput/Crank Report:zap:Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (3726) (6.275M) : 0, 6274917
master (6.266M) : 0, 6266471
benchmarks/2.22.0 (6.309M) : 0, 6309377
benchmarks/2.9.0 (6.101M) : 0, 6100845
section Instrumented
This PR (3726) (4.308M) : 0, 4308072
master (4.256M) : 0, 4255716
benchmarks/2.22.0 (4.312M) : 0, 4312460
benchmarks/2.9.0 (4.186M) : 0, 4186139
section Trace stats
master (4.342M) : 0, 4342103
benchmarks/2.22.0 (4.268M) : 0, 4268056
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (3726) (5.538M) : 0, 5538362
master (5.390M) : 0, 5390041
benchmarks/2.22.0 (5.149M) : 0, 5148985
benchmarks/2.9.0 (5.187M) : 0, 5187235
section Instrumented
This PR (3726) (3.748M) : 0, 3748064
master (3.650M) : 0, 3649503
benchmarks/2.22.0 (3.657M) : 0, 3657398
section Trace stats
master (3.566M) : 0, 3566011
benchmarks/2.22.0 (3.694M) : 0, 3693645
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (3726) (6.528M) : 0, 6527695
master (6.563M) : 0, 6563374
benchmarks/2.22.0 (6.565M) : 0, 6564616
benchmarks/2.9.0 (6.554M) : 0, 6553903
section Instrumented
This PR (3726) (4.468M) : 0, 4467954
master (4.411M) : 0, 4411415
benchmarks/2.22.0 (4.394M) : 0, 4393787
benchmarks/2.9.0 (4.581M) : 0, 4581063
section Trace stats
master (4.561M) : 0, 4561203
benchmarks/2.22.0 (4.412M) : 0, 4411809
gantt
title Throughput Linux x64 (ASM) (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (3726) (3.571M) : 0, 3570989
master (3.599M) : 0, 3598835
benchmarks/2.22.0 (3.602M) : 0, 3602458
benchmarks/2.9.0 (3.747M) : 0, 3747038
section No attack
This PR (3726) (1.256M) : 0, 1255985
master (1.241M) : 0, 1241364
benchmarks/2.22.0 (1.272M) : 0, 1271742
benchmarks/2.9.0 (1.274M) : 0, 1274356
section Attack
This PR (3726) (1.075M) : 0, 1074944
master (1.060M) : 0, 1059727
benchmarks/2.22.0 (1.082M) : 0, 1081655
benchmarks/2.9.0 (1.103M) : 0, 1103325
section Blocking
This PR (3726) (2.188M) : 0, 2188437
master (2.158M) : 0, 2157737
benchmarks/2.22.0 (2.109M) : 0, 2109348
|
Code Coverage Report 📊✔️ Merging #3726 into master will not change line coverage
View the full report for further details: Datadog.Trace Breakdown ✔️
The following classes have significant coverage changes.
View the full reports for further details: |
zacharycmontoya
approved these changes
Jan 30, 2023
albertvaka
approved these changes
Jan 30, 2023
|
I am still getting The process can not access the file because it is being used by another process. Is it fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR adds support for retries on IOExceptions when processing an assembly to add coverage information.
Reason for change
Sometimes the coverage datacollector throws an IOException because the assembly we try to modify is being used by another process. This appears to be a common problem in the coverage tools space, as we can see in the following issues:
With this PR we retry at least 3 times before failing to add coverage to an assembly.