[service_discovery] Adding container_name tag, ability to specify docker labels as tags #3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdwr98
force-pushed
the
service_discovery_docker_labels
branch
2 times, most recently
from
3856798
to
47d6bea
Compare
sdwr98
changed the title
sdwr98
force-pushed
the
service_discovery_docker_labels
branch
2 times, most recently
from
6708e2b
to
f51af49
Compare
…s in service discovery
sdwr98
force-pushed
the
service_discovery_docker_labels
branch
from
f51af49
to
2b3edf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces the ability to specify Docker labels as tags for metrics collected via service discovery, matching the feature that's already available in the docker_daemon integration. Also tags the metrics with the container_name, as the Docker integration does.
Motivation
Pulling metrics via service discovery is great, but without the ability to pull more information from the docker container, it's hard to correlate metrics with different applications.
Testing Guidelines
N/A
Additional Notes
Nope