Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mongo] add mongodb.rs_status service status for check state all replset members #3121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpidlisnyi
Copy link
Contributor

We want to control state of all members of replset. We should make sure that replset is healthy even we have only one DD agent on the one of replset nodes. For example during extension of cluster or shrinking. Our cluster has a lot of shards each has own replset. Therefore checking state of all replset members for each agent is useful.
We made a small patch with additional service check and we want to know your opinion about that. Would be great if you accept our code in official datadog agent repo.
Thank you

@gmmeyer
Copy link
Contributor

gmmeyer commented Feb 7, 2017

Hey @mpidlisnyi!

Thank you very much for your contribution! Unfortunately, this is a pretty big change and adds a new feature that is reasonably complex, so we're not going to be able to merge it before the next release. In the next release, we're moving to a slightly different model for the agent checks, where we're taking them out of this repo, and testing that to ensure it works will take up a good bit of our time.

Thank you again, your contribution is definitely appreciated :)

@gmmeyer gmmeyer assigned irabinovitch and unassigned gmmeyer Feb 7, 2017
@irabinovitch
Copy link
Contributor

@mpidlisnyi Thanks for this PR! As Greg mentioned we're currently migrating checks out this repo and into new https://github.com/DataDog/integrations-core and https://github.com/DataDog/integrations-extras. This change would fit into the https://github.com/DataDog/integrations-core repo.

The will enable a new release process that allows us to test, merge, and release integrations individually rather than waiting on a full dd-agent release.

Would it be OK if we close this PR and and as you to open a new one against the integrations-core repository?

Thank you for your patience as we have been working through this transition. If you have any questions, we are happy to discuss here in this PR or on Slack in #integrations. Our next community office hours and code review is tomorrow at 10:30am PT and we'd be happy to review a PR with you there if you'd like to join us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants