[CONTINT-3905] Make sure we retrieve the cgroup inode when the cid is not found #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliDatadog
force-pushed
the
ali/fix-cid-retrieval
branch
from
1c40ac1
to
da19659
Compare
AliDatadog
commented
Mar 7, 2024
| return | ||
| } | ||
| containerID = readMountinfo(selfMountInfoPath) | ||
| if containerID != "" { |
There was a problem hiding this comment.
The bug is just this line. All the rest is about moving stuff around to add unit tests
AliDatadog
force-pushed
the
ali/fix-cid-retrieval
branch
from
da19659
to
331d248
Compare
vboulineau
previously approved these changes
Mar 7, 2024
AliDatadog
changed the title
rayz
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the cgroup inode when the container id is
"".During testing of the last commit of this PR, we found out that the inode was sent and container tags was finally retrieved.
But actually, it was only because we had another bug in container id resolution that was fixed here. We were overriding a faulty container-id. We shouldn't override the container-id (actually it's not problematic). But we should at least retrieve the container-id when it's not found.
The new test cases should cover everything