[CONTINT-3864] Send both origin the container-id and the ENTITY_ID #300
Conversation
AliDatadog
changed the title
| @@ -886,9 +886,6 @@ func (c *Client) Close() error { | |||
| // - o.originDetection is explicitly set to false, which is true by default | |||
| func isOriginDetectionEnabled(o *Options) bool { | |||
| if !o.originDetection || o.containerID != "" { | |||
| // originDetection is explicitly disabled | |||
| // or DD_ENTITY_ID was found | |||
There was a problem hiding this comment.
nit: I would have left the rest of the comment but that's not a blocker.
wdhif
changed the title
|
Links to DataDog/datadogpy#828 |
wdhif
force-pushed
the
ali/fix-origin-detection
branch
from
642c790
to
8c18762
Compare
|
/merge |
|
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
dd-devflow
bot
added
mergequeue-status: queued
and removed
mergequeue-status: waiting
labels
|
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 0s) Use |
dd-devflow
bot
added
mergequeue-status: in_progress
mergequeue-status: error
and removed
mergequeue-status: queued
mergequeue-status: in_progress
labels
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 0s) Use |
We would like customers to be able to retrieve container tags even when
DD_ENTITY_IDis set to false. The current behavior does not send the container-id if the entity id is set.Note that the admission controller will set the container-id on Kubernetes.
For those who do not want container-tags, several alternatives are possible:
dd.internal.card=noneDD_ORIGIN_DETECTION_ENABLED=falseto the application podSee this doc for reference