uds: implement a connect timeout option #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test has been flaky for a while :/ |
vickenty
reviewed
Jan 2, 2024
vickenty
reviewed
Jan 11, 2024
vickenty
reviewed
Jan 16, 2024
This is similar to DataDog/java-dogstatsd-client#228
Co-authored-by: Vickenty Fesunov <vickenty@users.noreply.github.com>
Co-authored-by: Vickenty Fesunov <vickenty@users.noreply.github.com>
Co-authored-by: Vickenty Fesunov <vickenty@users.noreply.github.com>
iksaif
force-pushed
the
corentin.chary/disconnect
branch
from
0e2d18a
to
9489183
Compare
vickenty
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to DataDog/java-dogstatsd-client#228
The idea is to protect the client from starved connections (due to listener bugs) and reinitialise the connection as needed.