Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD_TAGS env var support #245

Closed
wants to merge 2 commits into from

Conversation

pedro-stanaka
Copy link

Summary

This PR fixes issue #223 and it is something that I am also interested in using. I hope this is the correct implementation for the problem.

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
Copy link
Author

@hush-hush I know you had self-assigned issue #223 to you, so maybe you want to give me a review here? Thanks in advance!

@hush-hush
Copy link
Member

Hi @pedro-stanaka ,

Thanks for opening this PR. Adding support for DD_TAGS across all our DogStatsD clients is something we're looking into.

The main issue being that when DD_TAGS is set for the whole host and the agent/client are running locally it will be picked by both, so we have to be careful. This is especially important when using containers, VMs or k8s deployments. The last thing we want is for the clients or Agent to assign the wrong tags to a metric by default.

We're also looking into aligning the behavior between all clients around this, which is a bit all over the place right now.

In the meantime, clients that want to fetch tags from the env can easily do so using the library constructor. It's not the best but it's an easy workaround.

@hush-hush hush-hush self-assigned this Dec 8, 2021
@hush-hush hush-hush added the hold label Dec 8, 2021
@hush-hush hush-hush assigned carlosroman and unassigned hush-hush Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants