Add support for DD_DOGSTATSD_HOST #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hush-hush
force-pushed
the
maxime/add-support-socket-env
branch
from
b7a0b15
to
5a2ec53
Compare
hush-hush
force-pushed
the
maxime/add-support-socket-env
branch
from
5a2ec53
to
959a933
Compare
hush-hush
changed the title
DD_DOGSTATSD_HOST takes precedence over DD_AGENT_HOST but works in the exact same way. This is useful when running multiple DogStatsD clients on the same host where each of them use a different UDS socket. For example the Trace agent might have its own UDS socket, "/var/run/datadog/apm.socket", while the Agent is listening on "/var/run/datadog/dsd.socket" for DogStatsD traffic. Setting "DD_AGENT_HOST" env var would set the same socket for both app. The dedicated "DD_DOGSTATSD_HOST" now allow users to set a socket/host for DogStatsD only.
hush-hush
force-pushed
the
maxime/add-support-socket-env
branch
from
959a933
to
8634aae
Compare
hush-hush
changed the title
|
This is actually already handled in all Trace agent except GO (cf: DataDog/dd-trace-go#1023) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DD_DOGSTATSD_HOSTtakes precedence overDD_AGENT_HOSTbut works in the exact same way. This is useful when running multiple DogStatsD clients on the same host where each of them use a different UDS socket.For example the Trace agent might have its own UDS socket,
/var/run/datadog/apm.socket, while the Agent is listening on/var/run/datadog/dsd.socketfor DogStatsD traffic. SettingDD_AGENT_HOSTenv var would set the same socket for both app. The dedicatedDD_DOGSTATSD_HOSTnow allow users to set a socket/host for DogStatsD only.This solves #201.