Add a Client test that can detect data races when emitting metrics from separate goroutines. #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hush-hush thanks for fixing the data race bug! Here's the test I used to confirm it was indeed an issue. Hopefully this will help catch data races in the future. |
…om separate goroutines.
matthewdale
force-pushed
the
test_client_data_race
branch
from
69648c2
to
474e496
Compare
hush-hush
approved these changes
Feb 12, 2021
|
Thanks for the test @matthewdale ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
statsd.Clienttest that can detect data races when recording metrics from separate goroutines.Inspired by the bug introduced in #178 and fixed with 5cfbb14.