Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picking up environment vars from file for trace-agent #25454

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

runlevel5
Copy link

What does this PR do?

Let trace-agent pick up common DD_* environment variables from /etc/datadog-agent/environment

Motivation

So that we have consistent way to configure daemons.

Possible Drawbacks / Trade-offs

Not that I am aware of. Unless the core team has different intention for this feature.

@runlevel5 runlevel5 requested a review from a team as a code owner May 8, 2024 05:42
@bits-bot
Copy link
Collaborator

bits-bot commented May 8, 2024

CLA assistant check
All committers have signed the CLA.

@spencergilbert
Copy link
Contributor

Thanks for the contribution @runlevel5 I don't see why we wouldn't include this here - and also why we shouldn't do so for the rest of the agent services. I'm going to check internally that there's no issues updating the other files. Assuming there isn't would you like to update those files as well, or should I commit those changes?

Additionally the failed CircleCI integration tests should pass when rebased, there was an issue with the docker-compose version that was being used - I believe our fix is on main at this point.

@spencergilbert spencergilbert self-assigned this May 10, 2024
@spencergilbert spencergilbert removed the request for review from a team May 10, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants