Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSPM] fix exponential backoff init #14556

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

paulcacheux
Copy link
Contributor

What does this PR do?

This PR fixes the creation of the backoff system in the node label fetching. We were not correctly using the constructor, as can be explained in this upstream issue cenkalti/backoff#120.

This was causing a lot of logs (from the notify callback) when the cluster agent communication was failing.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@paulcacheux paulcacheux added this to the 7.42.0 milestone Dec 1, 2022
@paulcacheux paulcacheux marked this pull request as ready for review December 1, 2022 15:28
@paulcacheux paulcacheux requested a review from a team as a code owner December 1, 2022 15:28
@paulcacheux paulcacheux merged commit c3863e4 into main Dec 2, 2022
@paulcacheux paulcacheux deleted the paulcacheux/fix-exp-backoff-setup-node-labels branch December 2, 2022 08:59
paulcacheux added a commit that referenced this pull request Dec 11, 2022
paulcacheux added a commit that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants