👷 [RUMF-1156] update wdio to latest version #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
force-pushed
the
benoit/update-wdio
branch
from
1fb2754
to
1ff70fc
Compare
BenoitZugmeyer
added
the
dependencies
BenoitZugmeyer
force-pushed
the
benoit/update-wdio
branch
3 times, most recently
from
b59b3d9
to
e749efe
Compare
Apparently, with new wdio packages, the browser is reading more data from request bodies at once (maybe because of a bigger buffer somewhere), and the margin used to check that the body is not read entirely was not enough. Still lower than the whole response, so the test is still ensuring that the whole response is not read.
The previous browsers configuration was not working because the new wdio packages are validating it (both with typechecking and runtime checks). With this commit, I try to improve how we define and pass browser configuration to both karma and e2e tests. I also made sure that we are running on the latest appium and selenium versions, to keep things up to date.
BenoitZugmeyer
force-pushed
the
benoit/update-wdio
branch
from
e749efe
to
1de0bd4
Compare
`capabilities.platformName` is never defined with our setup, so let's remove it to simplify the function.
BenoitZugmeyer
force-pushed
the
benoit/update-wdio
branch
from
bf41665
to
94c135e
Compare
amortemousque
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Keep packages up to date
Note: there is an issue observed with this new version, see webdriverio/webdriverio#8126 . Since it happens only when the spec fails in the first place, it shouldn't block us from upgrading
Changes
Testing
I have gone over the contributing documentation.