Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added platform-specific dependencies to Pipfile #30

Merged
merged 2 commits into from
Oct 4, 2022
Merged

fix: added platform-specific dependencies to Pipfile #30

merged 2 commits into from
Oct 4, 2022

Conversation

aleextw
Copy link
Contributor

@aleextw aleextw commented Sep 30, 2022

added colorama for win32 systems, updated bootstrap to remove deprecation warning

@issacj-17
Copy link

issacj-17 commented Sep 30, 2022

Testing on Windows

Updates have been tested on Windows 10 (64-bit). The web application is able to launch successfully. They have no visible points of failure when navigating apart from the code that needs to be implemented as part of the project (Mini Project 2 Exercises).

Testing on Ubuntu

Updates have also been tested on Ubuntu 22.04.1 LTS with the following adjustments via a Virtual Machine (VMWare Workstation) -
sudo apt-get remove python3-pipenv
sudo pip3 install pipenv (or sudo pip install pipenv)

They have failed on my system. However, the cause has been identified as per these issues on Github -
pypa/pipenv#5075
pypa/setuptools#3278

To keep it brief, it is due to the setuptools>=60.0.0 causing the virtualenv to create an abnormal tree structure on ubuntu 22.04.

It is therefore an OS dependent issue. This should not affect Vocareum given that it was able to run pipenv install and pipenv shell for mp_sort.

Additionally, Alex has tested Mini Project 2 on Debian and MacOS. The project is working as intended.

Summary:

Windows 10 (64-bit) : PASS
Debian : PASS
MacOS : PASS

The changes are successful and should have little to no problems when running on Vocareum.

@kurniawano
Copy link
Collaborator

@aleextw , can you change from Bootstrap4 to Bootstrap5 instead? See https://bootstrap-flask.readthedocs.io/en/stable/basic/#initialization. After that I will merge the pull request.

@aleextw
Copy link
Contributor Author

aleextw commented Oct 3, 2022

Updated Bootstrap4 to Bootstrap5 in code where necessary as per request

@kurniawano kurniawano merged commit 17fc544 into Data-Driven-World:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants