New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite migration: ESLint fixes #155
Open
NextFire
wants to merge
22
commits into
DakaraProject:develop
Choose a base branch
from
NextFire:vite-eslint
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've to check if everything works as expected.
These variables are exctracted from |
This is cleaner. |
jsconfig.json was loaded by editors such as vscode so their LSP could resolve aliases
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #154
eslint errors/warnings and applied fixes:
React
no-unused-vars
Remove unused React imports.
no-class-assign
and otherno-unused-vars
Disable these two rules. The second error was often raised on unused function arguments or object destructured properties that I believe were left for better readability and self-documentation.
no-case-declarations
Add
{}
.no-undef
Add
// eslint-disable-next-line
.This error was raised on
DAKARA_VERSION
,DAKARA_BUGTRACKER
andDAKARA_PROJECT_HOMEPAGE
that are defined invite.config.js
.react/display-name
Add
// eslint-disable-next-line
on four decorators in https://github.com/NextFire/dakara-client-web/blob/vite-eslint/src/components/adapted/ReactRouterDom.jsx.react/no-unescaped-entities
Escape characters.
react-refresh/only-export-components
Name some default exports + move two shared const to https://github.com/NextFire/dakara-client-web/blob/vite-eslint/src/utils/permissions.js.
react/prop-types
Add or complete
propTypes
on various components.I often had to guess when to add
isRequired
or not…