Issue checkstyle#7804: Resolve Pitest Issues - CustomImportOrderCheck…

… (3)
DXTkastb · Apr 18, 2020 · fc95f97 · fc95f97
1 parent 3dd76b5
commit fc95f97
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/.ci/pitest.sh b/.ci/pitest.sh
@@ -69,7 +69,6 @@ pitest-header)
 pitest-imports)
   mvn -e -P$1 clean test org.pitest:pitest-maven:mutationCoverage;
   declare -a ignoredItems=(
-  "CustomImportOrderCheck.java.html:<td class='covered'><pre><span  class='survived'>        if (bestMatch.group.equals(NON_GROUP_RULE_GROUP)) {</span></pre></td></tr>"
   "IllegalImportCheck.java.html:<td class='covered'><pre><span  class='survived'>        if (!result) {</span></pre></td></tr>"
   "ImportControlLoader.java.html:<td class='covered'><pre><span  class='survived'>        else if (ALLOW_ELEMENT_NAME.equals(qName) || &#34;disallow&#34;.equals(qName)) {</span></pre></td></tr>"
   "ImportOrderCheck.java.html:<td class='covered'><pre><span  class='survived'>                else if (matcher.start() == bestPos &#38;&#38; matcher.end() &#62; bestEnd) {</span></pre></td></tr>"

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/CustomImportOrderCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/CustomImportOrderCheck.java
@@ -786,18 +786,17 @@ else if (customOrderRules.contains(SAME_PACKAGE_RULE_GROUP)) {
                 bestMatch.matchLength = importPath.length();
             }
         }
-        if (bestMatch.group.equals(NON_GROUP_RULE_GROUP)) {
-            for (String group : customOrderRules) {
-                if (STANDARD_JAVA_PACKAGE_RULE_GROUP.equals(group)) {
-                    bestMatch = findBetterPatternMatch(importPath,
-                            STANDARD_JAVA_PACKAGE_RULE_GROUP, standardPackageRegExp, bestMatch);
-                }
-                if (SPECIAL_IMPORTS_RULE_GROUP.equals(group)) {
-                    bestMatch = findBetterPatternMatch(importPath,
-                            group, specialImportsRegExp, bestMatch);
-                }
+        for (String group : customOrderRules) {
+            if (STANDARD_JAVA_PACKAGE_RULE_GROUP.equals(group)) {
+                bestMatch = findBetterPatternMatch(importPath,
+                        STANDARD_JAVA_PACKAGE_RULE_GROUP, standardPackageRegExp, bestMatch);
+            }
+            if (SPECIAL_IMPORTS_RULE_GROUP.equals(group)) {
+                bestMatch = findBetterPatternMatch(importPath,
+                        group, specialImportsRegExp, bestMatch);
             }
         }
+
         if (bestMatch.group.equals(NON_GROUP_RULE_GROUP)
                 && customOrderRules.contains(THIRD_PARTY_PACKAGE_RULE_GROUP)
                 && thirdPartyPackageRegExp.matcher(importPath).find()) {