Issue checkstyle#8151: Update XpathRegressionOuterTypeNumber to have …

…atleast 2 tests
DXTkastb · Apr 28, 2020 · c473838 · c473838
1 parent 16ffa41
commit c473838
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 3 deletions.
diff --git a/config/checkstyle_non_main_files_suppressions.xml b/config/checkstyle_non_main_files_suppressions.xml
@@ -143,8 +143,6 @@
                files="src[\\/]it[\\/]java[\\/]org[\\/]checkstyle[\\/]suppressionxpathfilter[\\/]XpathRegressionNestedTryDepthTest.java"/>
     <suppress  id="numberOfTestCasesInXpath"
                files="src[\\/]it[\\/]java[\\/]org[\\/]checkstyle[\\/]suppressionxpathfilter[\\/]XpathRegressionOneTopLevelClassTest.java"/>
-    <suppress  id="numberOfTestCasesInXpath"
-               files="src[\\/]it[\\/]java[\\/]org[\\/]checkstyle[\\/]suppressionxpathfilter[\\/]XpathRegressionOuterTypeNumberTest.java"/>
     <suppress  id="numberOfTestCasesInXpath"
                files="src[\\/]it[\\/]java[\\/]org[\\/]checkstyle[\\/]suppressionxpathfilter[\\/]XpathRegressionSuppressWarningsHolderTest.java"/>
     <suppress  id="numberOfTestCasesInXpath"

diff --git a/src/it/java/org/checkstyle/suppressionxpathfilter/XpathRegressionOuterTypeNumberTest.java b/src/it/java/org/checkstyle/suppressionxpathfilter/XpathRegressionOuterTypeNumberTest.java
@@ -38,7 +38,28 @@ protected String getCheckName() {
     }
 
     @Test
-    public void testOne() throws Exception {
+    public void testDefault() throws Exception {
+        final File fileToProcess =
+            new File(getPath("SuppressionXpathRegressionOuterTypeNumberDefault.java"));
+
+        final DefaultConfiguration moduleConfig =
+            createModuleConfig(OuterTypeNumberCheck.class);
+
+        final String[] expectedViolation = {
+            "1:1: " + getCheckMessage(OuterTypeNumberCheck.class,
+                OuterTypeNumberCheck.MSG_KEY, 2, 1),
+        };
+
+        final List<String> expectedXpathQueries = Collections.singletonList(
+            "/PACKAGE_DEF"
+        );
+
+        runVerifications(moduleConfig, fileToProcess, expectedViolation,
+            expectedXpathQueries);
+    }
+
+    @Test
+    public void testMax() throws Exception {
         final File fileToProcess =
                 new File(getPath("SuppressionXpathRegressionOuterTypeNumber.java"));
 

diff --git a/...pressionxpathfilter/outertypenumber/SuppressionXpathRegressionOuterTypeNumberDefault.java b/...pressionxpathfilter/outertypenumber/SuppressionXpathRegressionOuterTypeNumberDefault.java
@@ -0,0 +1,9 @@
+package org.checkstyle.suppressionxpathfilter.outertypenumber; // warn
+
+public class SuppressionXpathRegressionOuterTypeNumberDefault {
+    public void test() {}
+}
+
+interface Constants {
+    int X = 10;
+}