Fix for improving user search. #3407
Open
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpinto1
force-pushed
the
fix-for-improving-user-search
branch
from
7467839
to
6808847
Compare
|
Will rebase with development once @benjaminfaure has released v4.2. That should fix test failures. |
johnpinto1
force-pushed
the
fix-for-improving-user-search
branch
from
6808847
to
ec8f36b
Compare
Currently Searches of users using search "firstname_<empty_spaces>_surname" will only get valid matches if the _<empty_spaces>_ is a single empty space. Change: The search term string is squished to remove extra empty spaces. As a result search terms like "Jill Bloggs" (one space between) and "Jill Bloggs" (more than one space between) will both return the same results.
johnpinto1
force-pushed
the
fix-for-improving-user-search
branch
from
ec8f36b
to
4e6995e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Searches of users using search "firstname_<empty_spaces>_surname" will only get valid matches if the <empty_spaces> is a single empty space.
Change:
The search term string is squished to remove extra empty spaces. As a
result search terms like "Jill Bloggs" (one space between) and "Jill Bloggs" (more than one space between) will both return the same results.
Reference:
https://api.rubyonrails.org/classes/String.html#method-i-squish