Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "You must answer at least ..." Message When default_percentage_answered is Set to Zero #3373

Closed
wants to merge 2 commits into from
Closed

Remove "You must answer at least ..." Message When default_percentage_answered is Set to Zero #3373

wants to merge 2 commits into from

Conversation

aaronskiba
Copy link
Contributor

Fixes #3372

Changes proposed in this PR:

  • If Rails.configuration.x.plans.default_percentage_answered is non-zero, then the visibility_message prior to this commit does not change. Otherwise, the "You must answer at least 0% of the questions to enable these options." part of the visibility_message is removed.

@aaronskiba aaronskiba added this to Review in Current sprint Jan 25, 2024
@aaronskiba aaronskiba linked an issue Jan 25, 2024 that may be closed by this pull request
Remove "You must answer at least ..." Message When default_percentage_answered is Set to Zero #3372
Open
@github-actions GitHub Actions
Copy link 

</tr>
1 Error
🚫

Please include a CHANGELOG entry.

You can find it at [CHANGELOG.md](https://github.com/DMPRoadmap/roadmap/blob/main/CHANGELOG.md).

Generated by 🚫 Danger

@aaronskiba aaronskiba marked this pull request as draft January 25, 2024 22:30
@aaronskiba aaronskiba marked this pull request as ready for review January 26, 2024 18:34
@aaronskiba aaronskiba marked this pull request as draft January 30, 2024 17:58
@aaronskiba
Avoid rendering "You must answer at least 0% ..."
6dd42e7 
Add extra handling for set_visibility_info. Only render "You must answer at least %{percentage}%% of the questions" when percentage is a non-zero value.
@aaronskiba
Test set_visibility_info with different percents
433ccb9
@aaronskiba aaronskiba closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Current sprint
Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "You must answer at least ..." Message When default_percentage_answered is Set to Zero
1 participant
@aaronskiba