updated README release section and updated gem dependencies #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsrust
reviewed
Nov 2, 2018
| @@ -132,9 +132,6 @@ gem 'mini_racer' | |||
| # Provides binaries for WKHTMLTOPDF project in an easily accessible package. | |||
| gem 'wkhtmltopdf-binary' | |||
|
|
|||
| # Puma is a simple, fast, threaded, and highly concurrent HTTP 1.1 server for Ruby/Rack applications (http://puma.io) | |||
| gem 'puma' | |||
There was a problem hiding this comment.
Good catch, not sure how this got in there twice
xsrust
approved these changes
Nov 2, 2018
| puts "\n== Copying sample files ==" | ||
| unless File.exist?("config/database.yml") | ||
| system "cp config/database.yml.sample config/database.yml" | ||
| system "cp config/branding.yml.sample config/branding.yml" |
There was a problem hiding this comment.
we should update this since we've changed the way we name these files
Suggested change
| system "cp config/branding.yml.sample config/branding.yml" | |
| system "cp config/database_example.yml config/database.yml" | |
| system "cp config/branding_example.yml config/branding.yml" |
There was a problem hiding this comment.
Perhaps a line to copy over the config/secrets_example.yml as well, that seems to be what travis is complaining about
There was a problem hiding this comment.
👍 Not sure what happened to them. They must have been in here somewhere for it to have been working at all before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
bundle updateto address the Loofah security issue (flavorjones/loofah#154) and update all of our other gems as well.
Updated the README to be less specific about the current version # and instead linked to the Releases page
Note that
jwt,sasscandsassc-railswere major version upgrades. We're of course going to do thorough testing of the new CSS changes but we should also double check our Shib and Orcid Oauth code which uses jwt.