test: Avoid errors when cross compile by gcc-8.3/9.2 #625

howjmay · 2024-01-07T03:57:00Z

Cross compiling with gcc-8.3 and gcc-9.2 would cause operand mismatch
error in some tests. The C code of some tests were compiled into
stange instructions. Fixing the error by not running the tests
when using gcc-8.3 and gcc-9.2

fixes #622

jserv · 2024-01-22T15:33:51Z

CI reported "gcc-arm-8.3-2019.02-x86_64-arm-linux-gnueabihf.tar.xz: Cannot open: No such file or directory". Can you check?

howjmay · 2024-01-27T07:16:43Z

@jserv
I am downloading gcc-8.3.0 from https://developer.arm.com/downloads/-/gnu-a
and run the cross tests with it. However it successfully passed the tests. Am I using the wrong source?

jserv · 2024-01-27T07:51:40Z

I am downloading gcc-8.3.0 from https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads
and run the cross tests with it. However it successfully passed the tests. Am I using the wrong source?

I extracted the GNU Toolchain to /tmp/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu on node1 machine, and it is still reproducible.

jserv@node1:~/sse2neon$ make CROSS_COMPILE=aarch64-linux-gnu- check
./sse2neon.h:110:2: warning: #warning "GCC versions earlier than 10 are not supported." [-Wcpp]
 #warning "GCC versions earlier than 10 are not supported."
  ^~~~~~~
/tmp/ccCwgoD5.s: Assembler messages:
/tmp/ccCwgoD5.s:41889: Error: operand mismatch -- `rev16 v0.4h,v0.4h'
/tmp/ccCwgoD5.s:41889: Info:    did you mean this?
/tmp/ccCwgoD5.s:41889: Info:            rev16 v0.8b, v0.8b
/tmp/ccCwgoD5.s:41889: Info:    other valid variant(s):
/tmp/ccCwgoD5.s:41889: Info:            rev16 v0.16b, v0.16b
...

jserv · 2024-02-29T19:29:16Z

I extracted the GNU Toolchain to /tmp/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu on node1 machine, and it is still reproducible.

Similarly, the following messages were raised by GitHub Actions:

/tmp/ccA3eMRR.s: Assembler messages:
/tmp/ccA3eMRR.s:41889: Error: operand mismatch -- `rev16 v0.4h,v0.4h'
/tmp/ccA3eMRR.s:41889: Info:    did you mean this?
/tmp/ccA3eMRR.s:41889: Info:    	rev16 v0.8b, v0.8b
/tmp/ccA3eMRR.s:41889: Info:    other valid variant(s):
/tmp/ccA3eMRR.s:41889: Info:    	rev16 v0.16b, v0.16b
/tmp/ccA3eMRR.s:74999: Error: operand mismatch -- `rev32 v0.4s,v0.4s'
/tmp/ccA3eMRR.s:74999: Info:    did you mean this?
/tmp/ccA3eMRR.s:74999: Info:    	rev32 v0.8b, v0.8b
/tmp/ccA3eMRR.s:74999: Info:    other valid variant(s):
/tmp/ccA3eMRR.s:74999: Info:    	rev32 v0.16b, v0.16b
/tmp/ccA3eMRR.s:74999: Info:    	rev32 v0.4h, v0.4h
/tmp/ccA3eMRR.s:74999: Info:    	rev32 v0.8h, v0.8h
/tmp/ccA3eMRR.s:94176: Error: operand mismatch -- `rev16 v0.8h,v0.8h'
/tmp/ccA3eMRR.s:94176: Info:    did you mean this?
/tmp/ccA3eMRR.s:94176: Info:    	rev16 v0.8b, v0.8b
/tmp/ccA3eMRR.s:94176: Info:    other valid variant(s):
/tmp/ccA3eMRR.s:94176: Info:    	rev16 v0.16b, v0.16b
/tmp/ccA3eMRR.s:113227: Error: operand mismatch -- `rev16 v0.8h,v0.8h'
/tmp/ccA3eMRR.s:113227: Info:    did you mean this?
/tmp/ccA3eMRR.s:113227: Info:    	rev16 v0.8b, v0.8b
/tmp/ccA3eMRR.s:113227: Info:    other valid variant(s):
/tmp/ccA3eMRR.s:113227: Info:    	rev16 v0.16b, v0.16b

howjmay · 2024-03-04T10:55:30Z

@jserv The problems was caused by the test code. sse2neon.h itself have no error on this bug. I have added the tests in this PR just for you to take a look. Once you think everything is OK I will remove them

jserv · 2024-03-04T11:01:26Z

@jserv The problems was caused by the test code. sse2neon.h itself have no error on this bug. I have added the tests in this PR just for you to take a look. Once you think everything is OK I will remove them

It sounds great. Please go ahead for fixing test code.

jserv · 2024-03-04T19:03:48Z

tests/impl.cpp

@@ -2813,26 +2813,31 @@ result_t test_mm_sfence(const SSE2NEONTestImpl &impl, uint32_t iter)

 result_t test_mm_shuffle_pi16(const SSE2NEONTestImpl &impl, uint32_t iter)
 {
+#if (__GNUC__ == 8 && __GNUC_MINOR__ == 3) || \


I wonder if gcc versions other than 8.3 and 9.2 encounter the same problem or not.

Is there any other version that suggested to check?

Is there any other version that suggested to check?

We have to clarify if the known issue appears in gcc version prior to 8.3.

I have added the supported versions in README. And I found even g++-8.4 would meet the same compiling error, therefore I have made the corresponding change in impl.cpp

jserv · 2024-03-24T09:32:52Z

README.md

@@ -60,6 +60,10 @@ reciprocal square root of `0.0`, then INF * `0.0` using `vmulq_f32`). In contras
 the SSE counterpart produces INF if a source value is `0.0`.
 As a result, additional treatments should be applied to ensure consistency between the conversion and its SSE counterpart.

+## Requirement
+
+We advise developers to utilize sse2neon.h with GCC version 10 or higher, or Clang version 11 or higher. While sse2neon.h might be compatible with earlier versions, certain vector operation errors have been identified in those versions. For further details, refer to the discussion in issue [#622](https://github.com/DLTcollab/sse2neon/issues/622).


Refine the text with a third-person view.

tests/impl.cpp

jserv · 2024-03-28T04:12:13Z

tests/impl.cpp

@@ -2813,26 +2813,29 @@ result_t test_mm_sfence(const SSE2NEONTestImpl &impl, uint32_t iter)

 result_t test_mm_shuffle_pi16(const SSE2NEONTestImpl &impl, uint32_t iter)
 {
+#if (__GNUC__ == 8) || (__GNUC__ == 9 && __GNUC_MINOR__ == 2)
+#error gcc-8.3, gcc-9.2 would cause operand mismatch error here


Refine the message:

Using older gcc versions can lead to an operand mismatch error. This issue affects all versions prior to gcc 10.

Cross compiling with gcc-8.3 and gcc-9.2 would cause operand mismatch error in some tests. The C code of some tests were compiled into stange instructions. Fixing the error by not running the tests when using gcc-8.3 and gcc-9.2 fixes DLTcollab#622

howjmay requested review from jserv and marktwtn as code owners January 7, 2024 03:57

jserv marked this pull request as draft January 22, 2024 04:06

howjmay force-pushed the fix-gcc-8-3 branch 8 times, most recently from e7a63fe to e16335b Compare January 27, 2024 07:07

howjmay force-pushed the fix-gcc-8-3 branch from 35af513 to a7271f6 Compare January 27, 2024 17:22

howjmay force-pushed the fix-gcc-8-3 branch 8 times, most recently from 9b55316 to c032914 Compare March 4, 2024 10:54

howjmay force-pushed the fix-gcc-8-3 branch from c032914 to d2f94c5 Compare March 4, 2024 14:50

howjmay changed the title ~~fix: Fix failed build on gcc-8.3~~ test: Avoid errors when cross compile by gcc-8.3/9.2 Mar 4, 2024

howjmay force-pushed the fix-gcc-8-3 branch 2 times, most recently from 5651202 to 0aa746d Compare March 4, 2024 14:54

howjmay marked this pull request as ready for review March 4, 2024 14:59

jserv reviewed Mar 4, 2024

View reviewed changes

howjmay force-pushed the fix-gcc-8-3 branch 4 times, most recently from 5b6e7be to 5be1d59 Compare March 21, 2024 08:14

jserv reviewed Mar 24, 2024

View reviewed changes

tests/impl.cpp Outdated Show resolved Hide resolved

howjmay force-pushed the fix-gcc-8-3 branch 2 times, most recently from 92b57d5 to fadc7c4 Compare March 28, 2024 04:01

jserv reviewed Mar 28, 2024

View reviewed changes

howjmay force-pushed the fix-gcc-8-3 branch 2 times, most recently from bf4cde5 to c84256a Compare March 29, 2024 15:49

howjmay force-pushed the fix-gcc-8-3 branch from c84256a to 8d33de1 Compare March 29, 2024 15:51

jserv merged commit 8df2f48 into DLTcollab:master Mar 29, 2024
16 checks passed

howjmay deleted the fix-gcc-8-3 branch March 29, 2024 16:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Avoid errors when cross compile by gcc-8.3/9.2 #625

test: Avoid errors when cross compile by gcc-8.3/9.2 #625

howjmay commented Jan 7, 2024 •

edited

jserv commented Jan 22, 2024

howjmay commented Jan 27, 2024 •

edited

jserv commented Jan 27, 2024

jserv commented Feb 29, 2024

howjmay commented Mar 4, 2024

jserv commented Mar 4, 2024

jserv Mar 4, 2024

howjmay Mar 6, 2024

jserv Mar 7, 2024

howjmay Mar 21, 2024

jserv Mar 24, 2024

howjmay Mar 29, 2024

jserv Mar 28, 2024

howjmay Mar 29, 2024

test: Avoid errors when cross compile by gcc-8.3/9.2 #625

test: Avoid errors when cross compile by gcc-8.3/9.2 #625

Conversation

howjmay commented Jan 7, 2024 • edited

jserv commented Jan 22, 2024

howjmay commented Jan 27, 2024 • edited

jserv commented Jan 27, 2024

jserv commented Feb 29, 2024

howjmay commented Mar 4, 2024

jserv commented Mar 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

howjmay commented Jan 7, 2024 •

edited

howjmay commented Jan 27, 2024 •

edited