Remove Kahan algorithm in _mm_dp_ps
#597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuda-Chen
force-pushed
the
improve-mm-dp-ps
branch
from
31dbe5c
to
6455daf
Compare
jserv
requested changes
May 18, 2023
There was a problem hiding this comment.
Consolidate the reason to drop Kahan algorithm in git commit messages.
Check https://cbea.ms/git-commit/ for general rules.
Remove Kahan algorithm in _mm_dp_ps to align conversion result with SSE. Also, apply shortcut when immediate is 0xXF and target is ARMv8-A. Last, add more tests for testing possible combinations of immediate including 0xXF. Close DLTcollab#595.
Cuda-Chen
force-pushed
the
improve-mm-dp-ps
branch
from
6455daf
to
424279b
Compare
Cuda-Chen
changed the title
_mm_dp_ps and its test cases_mm_dp_ps
|
Thank @Cuda-Chen for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Kahan algorithm in
_mm_dp_psto align conversion result with SSE.Also, apply shortcut when immediate is
0xXFand target is ARMv8-A.Last, add more tests for testing possible combinations of immediate
including
0xXF.Close #595.