Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Cover all the valid imm range in tests #586

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

howjmay
Copy link
Contributor

@howjmay howjmay commented Jan 22, 2023

No description provided.

@howjmay howjmay force-pushed the cover-imm-all branch 5 times, most recently from e23a0d6 to bbee2aa Compare January 22, 2023 11:35
tests/common.h Show resolved Hide resolved
@jserv
Copy link
Member

jserv commented Jan 23, 2023

Can you check C Pre-Processor Magic and see if the further tweaks can be applied?

@howjmay howjmay force-pushed the cover-imm-all branch 2 times, most recently from c43a13a to 8e52902 Compare June 1, 2023 17:43
@howjmay howjmay marked this pull request as ready for review June 2, 2023 02:32
@howjmay howjmay requested a review from marktwtn as a code owner June 2, 2023 02:32
@howjmay howjmay requested a review from jserv June 2, 2023 02:32
@jserv jserv requested a review from Cuda-Chen June 2, 2023 02:44
Copy link
Collaborator

@Cuda-Chen Cuda-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@jserv jserv merged commit d7a3035 into DLTcollab:master Jun 2, 2023
13 checks passed
@howjmay howjmay deleted the cover-imm-all branch June 3, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants