Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scmp series #6445

Closed
wants to merge 2 commits into from
Closed

Scmp series #6445

wants to merge 2 commits into from

Conversation

oppilate
Copy link
Contributor

该 PR 相关 Issue / Involved issue

Depends on #6444

完整路由地址 / Example for the proposed route(s)

/scmp/318198

There's an item with link containing series. It would break the feed. This patch fixes the problem.

@vercel
Copy link

vercel bot commented Dec 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/diy/rsshub/14mcax8rv
✅ Preview: https://rsshub-git-scmp-series.diy.vercel.app

@HenryQW
Copy link
Collaborator

HenryQW commented Dec 15, 2020

This PR should not include the UA changes.

@oppilate
Copy link
Contributor Author

oppilate commented Dec 15, 2020

Unfortuatenly there's a change to the UA variable. So it has to include the UA change or if the UA change is rejected it has to rollback that part.

@NeverBehave
Copy link
Collaborator

Hi, I believe we may have to separate these two: as the UA changes won't come in the short time.

If you still want to land the rss changes, it may have to done in the "ugly" way for now. Please advise.

@oppilate
Copy link
Contributor Author

Sure. Since the ua issue stucks, this issue should not depend on that anymore. Will do the job tomorrow.

@NeverBehave
Copy link
Collaborator

Sure. Since the ua issue stucks, this issue should not depend on that anymore. Will do the job tomorrow.

Cool, I will close this pr for now. open a new one when finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants