Style: aligned black with ruff settings, added pyupgrade #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstagni
changed the title
|
The issue that |
chrisburr
reviewed
Aug 31, 2023
|
This PR is ready to be merged. The only question I have is if ruff/pyupgrade should be forbidden to run on the auto-generated client code. |
chrisburr
reviewed
Sep 5, 2023
| @@ -22,8 +22,8 @@ | |||
| @app.async_command() | |||
| async def login( | |||
| vo: str, | |||
| group: Optional[str] = None, | |||
| property: Optional[list[str]] = Option( | |||
| group: Optional[str] = None, # noqa: UP007 | |||
There was a problem hiding this comment.
Shall we do this at the file level with a comment explaining why?
# ruff: noqa: F841
I think we definitely shouldn't, we just risk introducing bugs. |
Closed
|
Superseeded by #74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.