Fix gm-unit for skills above level 20 #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
reviewed
May 16, 2024
There was a problem hiding this comment.
Thanks! please add a line to the Misc Improvements section under the "Future" version in changelog.txt
Also, please feel free to add yourself to https://github.com/DFHack/dfhack/blob/develop/docs/about/Authors.rst (in a separate PR)
internal/gm-unit/editor_skills.lua
Outdated
| @@ -24,7 +24,13 @@ function list_skills(unit, learned_only) | |||
| u_skill={rating=-1,experience=0} | |||
| end | |||
| local rating | |||
| if u_skill.rating >=0 then | |||
| if u_skill.rating >15 then | |||
There was a problem hiding this comment.
Please use df.skill_rating.Legendary instead of the magic number 15
There was a problem hiding this comment.
I've replaced the magic number and added an entry in changelog.txt.
I'm unsure if I made the changelog entry correctly though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DFHack/dfhack#4579
