Fix dangling reference warning in buildingplan plugin #4540
Conversation
|
A version check is needed in the macro definition. :( |
|
updated I don't like this compiler/version check, it's too complex. Can it be better? Maybe you want to wait for your tool chain to update to gcc 14 before fixing this issue. |
|
"All attributes unknown to an implementation are ignored without causing an error" so if an undefined attribute is causing a compilation error this itself is a compiler bug. |
|
We are not likely to move to gcc 14 any time soon due to basically nonexistent support for gcc 14's runtime in widely available distributions. Building DFHack with a version of gcc other than the one DF is built with (currently gcc 11) is unsupported. |
It causes a warning and with
Yes, forget about this. I'll keep my workaround in my cmake configuration. |
I think this can still be a useful addition. we don't distribute DFHack built with newer compilers, but we do build with newer compilers. We build with gcc-12 in CI, for example, to catch warnings that gcc-10 misses. |
|
I would use the "pragma" approach to disable the warnings instead of using an attribute, since (I sincerely hope) that no compiler author is doofus enough to issue even so much as a warning for an unrecognized pragma. 🤦♀️ |
| @@ -15,6 +15,12 @@ | |||
| #include "df/organic_mat_category.h" | |||
| #include "df/world.h" | |||
|
|
|||
| #if (defined(__GNUC__) && !defined(__clang__) && __GNUC__ >= 14) | |||
There was a problem hiding this comment.
could also be #if __has_cpp_attribute(no_dangling), I think
There was a problem hiding this comment.
fix #4534