Replace editor bullet point button with hint text #6845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app https://teaching-vacancies-review-pr-6845.test.teacherservices.cloud was successfully deleted |
scruti
force-pushed
the
replace-editor-bulletpoint-button-with-hint-text
branch
from
14eb790
to
735eee1
Compare
The text editor "toggle bulletpoint" button was highlighted as an accessibility issue in our recent accessibility assessment. The team decided that is not worth to keep it and we can just display a hint text instead.
scruti
force-pushed
the
replace-editor-bulletpoint-button-with-hint-text
branch
from
735eee1
to
75247a8
Compare
scruti
commented
May 10, 2024
| .govuk-hint id="#{@field_name}-hint" | ||
| = @hint | ||
| .govuk-hint id="#{@field_name}-hint" | ||
| = @hint.presence || "You can copy and paste any information and keep bullet point formatting." | ||
| .editor-component__toolbar data-editor-target="toolbar" |
There was a problem hiding this comment.
Removing this line breaks the input behaviour. So I ended up leaving it while removing the toolbar button only.
KyleMacPherson
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
Changes in this PR:
The text editor "toggle bullet point" button was highlighted as an accessibility issue in our recent accessibility assessment.
The team decided it was not worth keeping it and we can display a hint text instead.
Screenshots of UI changes:
Before
After