Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Teaching" roles category to "Teaching & leadership" #6843

Merged
merged 13 commits into from May 22, 2024

Conversation

KyleMacPherson
Copy link
Collaborator

@KyleMacPherson KyleMacPherson commented May 8, 2024

Trello card URL

https://trello.com/c/SWQWOjLs/977-update-job-role-categories-to-be-teaching-leadership-then-support-merge-teaching-support-and-non-teaching-support

Changes in this PR:

  • Teaching category changed to Teaching & leadership
  • Combine ‘Teaching support’ and ‘Non-teaching support’ categories into ‘Support’ category
  • Remove the “Other teaching support” job role
  • Add a rake task to change all vacancies with “Other teaching support” to "Other support" role (Currently 4 in production)

Screenshots of UI changes:

Before

After

Next steps:

  • Terraform deployment required?

  • New development configuration to be shared?

@KyleMacPherson KyleMacPherson marked this pull request as draft May 8, 2024 10:45
@KyleMacPherson KyleMacPherson force-pushed the update-role-categories branch 9 times, most recently from 4fceaf7 to 29f75db Compare May 13, 2024 09:40
@KyleMacPherson KyleMacPherson marked this pull request as ready for review May 13, 2024 10:11
Copy link

github-actions bot commented May 13, 2024

Review app https://teaching-vacancies-review-pr-6843.test.teacherservices.cloud was successfully deleted

Copy link
Collaborator

@scruti scruti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KyleMacPherson KyleMacPherson merged commit d42451d into main May 22, 2024
14 checks passed
@KyleMacPherson KyleMacPherson deleted the update-role-categories branch May 22, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants