Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 3 quick ways to find the right teaching job for you content page #6841

Merged
merged 4 commits into from May 13, 2024

Conversation

EllieNodder
Copy link
Collaborator

Trello card URL

https://trello.com/c/vd5Ao9xw/990-schedule-benefits-of-tv-account-email-and-create-content

Changes in this PR:

  • Adding a new page of content to the jobseeker guides ready for a New Teachers Campaign email

  • Is there anything specific you want feedback on?

Hopefully I've just copied across what the other content pages look like, but let me know if I've accidentally broken anything!!!

Screenshots of UI changes:

Before

After

Next steps:

  • Terraform deployment required?

  • New development configuration to be shared?

@EllieNodder
Copy link
Collaborator Author

is there a way to generate a review app so that @alexleedfe can review? @scruti

order: 500
title: 3 quick ways to find the right teaching job for you
meta_description: Congratulations, you’ve been invited to an interview for a teaching job! What’s next? We’ve spoken to experienced teachers to get their top tips for success including how to prepare answers to interview questions.
date_posted: 07/05/2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexleedfe assuming this is just a classic gov.uk/GDS pattern, but wondering if we need/how helpful the date posted is?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexleedfe just chucked in a random image, but I dunno if these are the right dimensions etc and would need to run by Sophie/branding to check we can use any of the new imagery

@EllieNodder EllieNodder changed the title Adding-new-using-tv-content-for-jobseekers Adding 3 quick ways to find the right teaching job for you content page May 7, 2024
@EllieNodder EllieNodder requested a review from scruti May 7, 2024 16:47
@scruti scruti added the deploy label May 9, 2024
scruti added 2 commits May 9, 2024 10:13
…ontent-for-jobseekers

* origin/main: (21 commits)
  Replace deprecated Github action for AWS secrets
  Add GetParameters permission to Deployments role
  Fix typo
  Bump the npm-dependencies group with 3 updates
  Change replace_training_and_cpds to replace_training_and_cpds! to show that the jobseeker_profile is modified by this method
  Remove content block from posts
  Bump the gem-dependencies group across 1 directory with 7 updates
  Bump dfe-analytics from v1.12.4 to v1.12.6
  Reverse changes to jobseeker_profiles/new
  Re-organise schema column order
  Fix test assertion failing with gem upgrade
  Bump mail-notify from 1.2.0 to 2.0.0
  Remove strings from views and add them to i18n files
  Remove unused confirm_destroy and review pages for training and cpds
  Set training_and_cpds_completed to true in job_applications factory as default
  Add incomplete warning for training and cpd section of the job application
  Linting
  Add new fields to analytics.yml
  Allow users to update training and cpds data on profile from the job application form
  Allow users to add/edit/delete training and cpd on job applications
  ...
…ontent-for-jobseekers

* origin/main:
  Upgrade Alpine Glib vulnerable version on Docker
Copy link

github-actions bot commented May 9, 2024

Review app https://teaching-vacancies-review-pr-6841.test.teacherservices.cloud was successfully deleted

@EllieNodder EllieNodder merged commit d93f732 into main May 13, 2024
14 checks passed
@EllieNodder EllieNodder deleted the adding-new-using-tv-content-for-jobseekers branch May 13, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants