Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop ESLint errors from blocking compilation #27

Merged
merged 1 commit into from Apr 29, 2021

Conversation

jkempster34
Copy link
Contributor

Description

Stop ESLint errors from blocking compilation

Motivation and Context

There is a known bug where ESLint errors will prevent React compiling. This is really annoying when developing, as even an unused import will result in an error (see image below). react-scripts 4.0.3 has fixed this but requires setting the ESLINT_NO_DEV_ERRORS environment variable.

Screenshots (if appropriate):

Before change (error showing in browser):
image

After change (warning in console only):
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link

@jkempster34 jkempster34 merged commit 6cd9a8a into main Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants